test: cover dated MSA lower bound on refresh (CM-1180)

[skwowet]

Summary

• Follow-up to test: cover member organization affiliations (CM-1180) #4327: the dated-MSA refresh case only seeded activities inside and after the window, so removing dateStart checks would still pass.
• Add a pre-window activity batch and include it in the employer count so both MSA boundaries are locked.

Test plan

• pnpm --filter @crowd/data-access-layer test member-organization-affiliation (or the suite’s usual vitest target)
• Confirm sponsor stays at 40 (in-window) and employer is 50 (20 pre + 30 post)

Made with Cursor

[Copilot]

Pull request overview

Adds regression coverage for the dated-MSA lower boundary during affiliation refresh.

Changes:

• Seeds 20 pre-window activities.
• Verifies employer retains all 50 out-of-window activities.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Comments suppressed due to low confidence (2)

services/libs/data-access-layer/src/affiliations/index.test.ts:12

• This block misstates the referenced testing ADRs. ADR-0007 explicitly prefers inline fixtures, and ADR-0008 requires named scenarios—not DB-backed tests; this suite already uses named it(...) scenarios. Please describe the actual isolation/style difference without presenting these choices as ADR violations.
  services/libs/data-access-layer/src/affiliations/index.test.ts:21
• The direct ./index import loads a module that imports BLACKLISTED_MEMBER_TITLES from ../members/base, but the hoisted mock below still targets ../../members/base, which does not exist from this directory. As a result, the intended stub does not intercept the dependency and the heavy real module is loaded; update the mock specifier to match the production import.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Comments suppressed due to low confidence (2)

services/libs/data-access-layer/src/affiliations/index.test.ts:12

• This says the suite violates ADR-0008 because it lacks “named DB-backed scenarios,” but ADR-0008 requires named scenarios—not database-backed tests—and this file already uses named it(...) cases. Rephrase the note without attributing the mocked-vs-DB-backed distinction to that ADR.
  services/libs/data-access-layer/src/affiliations/index.test.ts:21
• The corrected ./index import loads ../members/base, but the hoisted stub below still targets the nonexistent ../../members/base. It therefore does not intercept the production dependency as the comment claims. Point the mock at the same module path used by affiliations/index.ts.