Skip to content

refactor: new docker image pattern (CM-1171) - #4522

Merged
ulemons merged 1 commit into
mainfrom
fix/update-worker-image
Aug 28, 2026
Merged

refactor: new docker image pattern (CM-1171)#4522
ulemons merged 1 commit into
mainfrom
fix/update-worker-image

Conversation

@ulemons

@ulemons ulemons commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

use new pattern for docker image

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

JIRA ticket

CM-1171

Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
@ulemons ulemons self-assigned this Aug 28, 2026
Copilot AI balanced review requested due to automatic review settings August 28, 2026 08:14
@cursor

cursor Bot commented Aug 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Build-only Dockerfile refactor with no application code changes; main risk is a broken or larger image if the new base or pnpm setup diverges from other workers.

Overview
Updates Dockerfile.automatic_onboarding_worker to match the newer service image pattern used elsewhere (e.g. other workers).

The builder stage moves from node:24-alpine to node:24-bookworm-slim, with native build deps installed via apt-get instead of apk. Dependency prefetch now copies package.json up front and uses corepack enable && corepack prepare --activate instead of globally installing Corepack and pinning pnpm@9.15.0.

The runner stage adds pnpm_config_verify_deps_before_run=false, copies package.json before Corepack setup, and uses the same Corepack activation approach (still on bookworm-slim with ca-certificates).

Reviewed by Cursor Bugbot for commit 9d14cdf. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the automatic onboarding worker image with the repository’s newer Docker build pattern.

Changes:

  • Uses Debian slim for builder and runner stages.
  • Sources pnpm via the root packageManager configuration.
  • Adds runtime dependency-verification configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ulemons
ulemons merged commit 7f82c65 into main Aug 28, 2026
18 checks passed
@ulemons
ulemons deleted the fix/update-worker-image branch August 28, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants