Skip to content

Report detailed drawers#461

Merged
joanagmaia merged 10 commits into
mainfrom
feature/reports-detailed-drawers
Feb 1, 2023
Merged

Report detailed drawers#461
joanagmaia merged 10 commits into
mainfrom
feature/reports-detailed-drawers

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Refactor doExport member actions to receive specific member ids and custom filters instead of just supporting the ones in members list view
  • Add new endpoint to member-service to get the list of active members
  • Updates on report's tooltip
    • Add footerBtn if value is passed
    • Allow pointer events
    • Dispatch mouse events from tooltip to canvas so that tooltip is still shown when hovered
  • Add event emitter to widget-area to allow widgets to handle the tooltip click with specific actions
  • Create widget-drawer component to handle all report's detailed drawers
  • Refactor widget-members-table to accommodate some needed styles for the detailed drawers
  • Add drawer and related requests to all members report's widget

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Feature Created by Linear-GitHub Sync label Jan 26, 2023
@joanagmaia joanagmaia requested a review from mariobalca January 26, 2023 11:42
@joanagmaia joanagmaia self-assigned this Jan 26, 2023
@joanagmaia joanagmaia requested a review from epipav January 26, 2023 14:16
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work once again! Looks ready to be shipped 💪

.join(',')
}),
...(isTeamMember === false && {
'filter[isTeamMember]': isTeamMember
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to add the filter[isBot]: isBot here as well after/while merging the #465

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up! I'll wait for your PR to update this branch

@joanagmaia joanagmaia requested a review from themarolt February 1, 2023 16:08
@joanagmaia joanagmaia merged commit 9d4ed13 into main Feb 1, 2023
@joanagmaia joanagmaia deleted the feature/reports-detailed-drawers branch February 1, 2023 17:16
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Co-authored-by: Uroš Marolt <uros@crowd.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants