Skip to content

LinkedIn integration service optimization#464

Merged
themarolt merged 1 commit into
mainfrom
enhancement/linkedin-integration-service-optimization-C-537
Jan 30, 2023
Merged

LinkedIn integration service optimization#464
themarolt merged 1 commit into
mainfrom
enhancement/linkedin-integration-service-optimization-C-537

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • We spam GET /member linkedin API endpoint quite hard so I added redis cache because a lot of the reactions and comments are done by the same people over and over again and this reduced API calls by more than 50%
  • For non-onboarding integration triggers I added a check so that we don't look for comments and reactions beyond those that we already looked for or 1 month back. This should optimize request count for reactions and comments as well - the only downside is that we might miss some nested comments with this...

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@themarolt themarolt requested a review from epipav January 27, 2023 13:32
@themarolt themarolt merged commit 242f74b into main Jan 30, 2023
@themarolt themarolt deleted the enhancement/linkedin-integration-service-optimization-C-537 branch January 30, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants