Skip to content

Non existing member attributes in settings#476

Merged
epipav merged 2 commits into
mainfrom
bugfix/non-existing-attributes-in-settings
Jan 31, 2023
Merged

Non existing member attributes in settings#476
epipav merged 2 commits into
mainfrom
bugfix/non-existing-attributes-in-settings

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Jan 31, 2023

We have some attributes in some members that are non existing in member attribute settings.
This is probably happened after migrating data to dynamic attributes.

  • Now instead of throwing a 400 error, we're deleting the non-existing attribute from the payload before upserting the member. This will also enable us to clear up the already existing member attributes data.
  • Also fixes the wrong calculation of seconds until end of month when it's the last day of the month.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav self-assigned this Jan 31, 2023
@epipav epipav requested a review from themarolt January 31, 2023 09:44
@epipav epipav added the Bug Created by Linear-GitHub Sync label Jan 31, 2023
@epipav epipav marked this pull request as ready for review January 31, 2023 10:36
@epipav epipav merged commit 36019f8 into main Jan 31, 2023
@epipav epipav deleted the bugfix/non-existing-attributes-in-settings branch January 31, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants