Skip to content

Only use posts that have publishedAt property set.#718

Merged
themarolt merged 1 commit intomainfrom
bugfix/linkedin-404-posts-fix-C-1088
Apr 3, 2023
Merged

Only use posts that have publishedAt property set.#718
themarolt merged 1 commit intomainfrom
bugfix/linkedin-404-posts-fix-C-1088

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • For some posts we were getting 404 when fetching their comments/reactions - the only difference was that those posts didn't have publishedAt property returned from LinkedIn API so we are filtering those out for now

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Apr 3, 2023
@themarolt themarolt requested a review from epipav April 3, 2023 11:38
@themarolt themarolt merged commit 52e1cd1 into main Apr 3, 2023
@themarolt themarolt deleted the bugfix/linkedin-404-posts-fix-C-1088 branch April 3, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants