Skip to content

Fixed member joinedAt being overwritten for the Slack and Twitter integrations#729

Merged
joanreyero merged 5 commits intomainfrom
bugfix/joinedAt
Apr 6, 2023
Merged

Fixed member joinedAt being overwritten for the Slack and Twitter integrations#729
joanreyero merged 5 commits intomainfrom
bugfix/joinedAt

Conversation

@joanreyero
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero commented Apr 6, 2023

Changes proposed ✍️

When we onboarded we set the follow timestamp to 1970, and the member’s joinedAt as well. So far so good.
But when we onboard, we upsert that same activity with timestamp now(). The upsert for activities was working fine. However, when it was calling the upsert for members, it was sending the timestamp now() as joinedAt , when it should have been sending the timestamp of the existing activity.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanreyero joanreyero added the Bug Created by Linear-GitHub Sync label Apr 6, 2023
@joanreyero joanreyero changed the title Fixed joinedAts being overwriten Fixed member joinedAt being overwritten for the Slack and Twitter integrations Apr 6, 2023
@joanreyero joanreyero merged commit c2f0ee0 into main Apr 6, 2023
@joanreyero joanreyero deleted the bugfix/joinedAt branch April 6, 2023 12:48
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants