Skip to content

Issue when deleting sample data on onboarding integration#733

Merged
themarolt merged 2 commits intomainfrom
bugfix/sample-tenant-data-deletion-fails-C-1132
Apr 7, 2023
Merged

Issue when deleting sample data on onboarding integration#733
themarolt merged 2 commits intomainfrom
bugfix/sample-tenant-data-deletion-fails-C-1132

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Apr 6, 2023

Changes proposed ✍️

  • When trying to delete sample data permission checker error gets thrown - no permission to edit tenant so I added a force flag to bypass that permission check if we are doing updates from our internal services
  • Sample data deletion was not in transaction so I fixed that as well because in this case the last function call failed but then it failed earlier since some other data was already gone. It should be rolled back.
  • Removed a bunch of console.log statements since they are blowing up our log usage

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Apr 6, 2023
@themarolt themarolt requested a review from joanreyero April 6, 2023 17:11
@themarolt themarolt merged commit 68dd35c into main Apr 7, 2023
@themarolt themarolt deleted the bugfix/sample-tenant-data-deletion-fails-C-1132 branch April 7, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant