Skip to content

Bugfix/member upsert doesn't always work when called from integrations#793

Merged
themarolt merged 2 commits intomainfrom
bugfix/member-upsert-doesnt-always-work-C-1224
Apr 21, 2023
Merged

Bugfix/member upsert doesn't always work when called from integrations#793
themarolt merged 2 commits intomainfrom
bugfix/member-upsert-doesnt-always-work-C-1224

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Apr 21, 2023 •
edited
Loading

Changes proposed ✍️

What

  • sometimes ActivityService.createWithMember was called with the incorrectly formatted activity or member or both
  • MemberService.update and MemberService.upsert when called with an existing identity in some cases didn't correctly propagate the changes to the database - it tried to insert the same identity for a member that already had it

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Fixing issue where some ActivityService.createWithMember calls didn't…
037b95c 
… have username set and members were not in the correct format
@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Apr 21, 2023
@themarolt themarolt requested a review from joanreyero April 21, 2023 15:17
@themarolt themarolt marked this pull request as ready for review April 21, 2023 15:20
joanreyero
joanreyero approved these changes Apr 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit

Comment thread backend/src/database/repositories/memberRepository.ts Outdated
@themarolt themarolt merged commit 0dc8b44 into main Apr 21, 2023
@themarolt themarolt deleted the bugfix/member-upsert-doesnt-always-work-C-1224 branch April 21, 2023 16:58
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Bugfix/member upsert doesn't always work when called from integrations (
ef02590 
#793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joanreyero joanreyero joanreyero approved these changes

Assignees

No one assigned

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@themarolt @joanreyero