Skip to content

isTeamMember check fix for new activity automation#845

Merged
epipav merged 2 commits intomainfrom
bugfix/isTeamMember-check-in-automations
May 10, 2023
Merged

isTeamMember check fix for new activity automation#845
epipav merged 2 commits intomainfrom
bugfix/isTeamMember-check-in-automations

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented May 10, 2023

Changes proposed ✍️

  • We were checking attributes.isTeamMember.custom, instead we should check attributes.isTeamMember.default

What

🤖 Generated by Copilot at 06b5a6c

Fixed a bug in newActivityWorker.ts that caused team member activities to be skipped. Changed the logic to use the default property of the isTeamMember attribute instead of the custom property.

🤖 Generated by Copilot at 06b5a6c

shouldProcessActivity
uses default now, not custom
bug fixed in autumn

Why

How

🤖 Generated by Copilot at 06b5a6c

  • Fix bug where team member activities were not processed correctly by using the default property of the isTeamMember attribute (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav added the Bug Created by Linear-GitHub Sync label May 10, 2023
@epipav epipav self-assigned this May 10, 2023
@epipav epipav requested a review from themarolt May 10, 2023 08:57
@epipav epipav marked this pull request as ready for review May 10, 2023 08:57
@epipav epipav merged commit 197fa15 into main May 10, 2023
@epipav epipav deleted the bugfix/isTeamMember-check-in-automations branch May 10, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants