Soft-delete integrations when removing them#855
Merged
sausage-todd merged 1 commit intomainfrom May 15, 2023
Merged
Conversation
joanreyero
reviewed
May 12, 2023
Contributor
joanreyero
left a comment
There was a problem hiding this comment.
Congrats on your first PR! 🚀
Curious about what will happen if we:
- connect an integration
- disconnect
- connect again
Could you send this to staging and try it out?
2d0fa4d to
9edd595
Compare
Contributor
Author
|
These are very good questions, let me see |
themarolt
reviewed
May 15, 2023
Contributor
Author
|
Ok, so here's how it works:
|
themarolt
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 2d0fa4d
Removed
forceoption fromsyncmethod inintegrationRepository.tsto prevent data loss. This is part of a pull request to improve the database configuration and migrations for the backend.
🤖 Generated by Copilot at 2d0fa4d
Why
To make troubleshooting/debugging of integrations easier
How
🤖 Generated by Copilot at 2d0fa4d
forceoption fromsyncmethod ofIntegrationRepositoryclass to prevent table dropping and data loss (link)Checklist ✅
Feature,Improvement, orBug.