Merged
Conversation
joanagmaia
reviewed
May 29, 2023
Contributor
joanagmaia
left a comment
There was a problem hiding this comment.
Great work!
Just left one request to change a button style and also noticed that you are missing to add discourse svg icon to frontend/public/icons/crowd-icons.svg (in some components we render the platform as svg)
Could you update those 2 things?
themarolt
requested changes
May 29, 2023
joanagmaia
approved these changes
May 29, 2023
themarolt
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 6868584
This pull request adds support for Discourse integration to the backend. It implements new API routes, functions, and classes to handle the connection, validation, webhook, and data fetching logic for Discourse. It also updates the integration processor, the grid system, the member attributes, and the incoming webhook repository to accommodate the Discourse integration. It modifies the files
backend/src/serverless/integrations/services/integrationProcessor.ts,backend/src/api/integration/index.ts,backend/src/api/webhooks/index.ts,backend/src/database/attributes/member/discourse.ts,backend/src/database/repositories/incomingWebhookRepository.ts,backend/src/serverless/integrations/grid/discordGrid.ts, andbackend/src/services/integrationService.ts, and adds several new files underbackend/src/api/integration/helpers,backend/src/api/webhooks,backend/src/serverless/integrations/grid, andbackend/src/serverless/integrations/usecases/discourse.
🤖 Generated by Copilot at 6868584
Why
How
🤖 Generated by Copilot at 6868584
discourseCreateOrUpdate,discourseSoftConnect,discourseTestWebhook, anddiscourseValidator(link, link, link, link)backend/src/api/integration/index.ts(link)discourse(link)backend/src/api/webhooks/index.ts(link)DiscourseGrid(link)topic(link)DiscourseIntegrationServiceclass to the array of integration services in theIntegrationProcessorclass (link, link)checkWebhooksExistForIntegration(link)URL,BIO, andAVATAR_URL(link)discourseConnectOrUpdateanddiscourseSoftConnect(link)getDiscourseCategories,getDiscourseTopics,getDiscoursePostsByIds,getDiscoursePostsFromTopic, andgetDiscourseUserByUsername(link, link, link, link, link)Checklist ✅
Feature,Improvement, orBug.