Skip to content

fix github webhook early return#917

Merged
garrrikkotua merged 1 commit intomainfrom
hotfix/github-webhook
May 30, 2023
Merged

fix github webhook early return#917
garrrikkotua merged 1 commit intomainfrom
hotfix/github-webhook

Conversation

@garrrikkotua
Copy link
Copy Markdown
Contributor

@garrrikkotua garrrikkotua commented May 30, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 334afe5

Fixed a bug in GithubIntegrationService that prevented webhook creation. Removed an unnecessary return statement from createGithubWebhook method in backend/src/serverless/integrations/services/integrations/githubIntegrationService.ts.

🤖 Generated by Copilot at 334afe5

createGithubWebhook
No more early return - bug fixed
Webhooks blossom in spring

Why

How

🤖 Generated by Copilot at 334afe5

  • Fix bug that prevented webhook creation for Github integrations by removing unnecessary return statement (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua added the Bug Created by Linear-GitHub Sync label May 30, 2023
@garrrikkotua garrrikkotua merged commit 4ce1efb into main May 30, 2023
@garrrikkotua garrrikkotua deleted the hotfix/github-webhook branch May 30, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants