Retrying error state webhooks and cleanup for orphaned ones#923
Merged
Conversation
…CrowdDotDev/crowd.dev into improvement/retry-for-incoming-webhooks
themarolt
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
When checking stuck webhooks, now we also set the error state webhooks to pending state that wasn't tried 5 times. This will help retrying the error state webhooks again.
When marking a webhook as error, we now also update the retry count.
New cleanup function:
cleanUpOrphanedWebhooksremoves the orphaned webhooks from the database that doesn't belong to any integrations anymoreWhat
🤖 Generated by Copilot at 3b87e50
This pull request implements a new feature to retry incoming webhooks based on their state and error. It modifies the
incomingWebhookRepositoryclass, theincomingWebhookstable, and theWebhookProcessorservice to support this functionality. It also includes migration scripts to update the database schema.
🤖 Generated by Copilot at 3b87e50
Why
How
🤖 Generated by Copilot at 3b87e50
Checklist ✅
Feature,Improvement, orBug.