Skip to content

Fixing a few issues with unleash and new services#927

Merged
themarolt merged 2 commits intomainfrom
bugfix/feature-flags-issues
Jun 1, 2023
Merged

Fixing a few issues with unleash and new services#927
themarolt merged 2 commits intomainfrom
bugfix/feature-flags-issues

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Jun 1, 2023

  • a queue was missing when connecting devto/linkedin and integration-run-worker was not being started before (to create the queue)
  • unleash init script was broken after organization enrichment was added
  • seconds until the end of month were being wrongly calculated

Changes proposed ✍️

What

🤖 Generated by Copilot at 697a5d9

This pull request implements the organization enrichment feature as a premium service, and refactors the codebase to remove the dependency on the @crowd/common package. It adds new feature flags, SQS queues, and API endpoints for the feature, and updates the import paths for the getSecondsTillEndOfMonth function to use the local utils/timing module. It also improves the scripts/cli file with new commands and functions.

🤖 Generated by Copilot at 697a5d9

The @crowd/common package was a pain
So we refactored it again and again
We moved getSecondsTillEndOfMonth
To a local module with more punch
And updated the imports in our domain

Why

How

🤖 Generated by Copilot at 697a5d9

  • Move and update import paths for getSecondsTillEndOfMonth function (link, link, link, link, link, link, link, link)
  • Add feature flag and SQS queues for organization enrichment feature (link, link)
  • Add echo command and install_libs function to scripts/cli file (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

- a queue was missing when connecting devto/linkedin and integration-run-worker was not being started before (to create the queue)
- unleash init script was broken after organization enrichment was added
- seconds until the end of month were being wrongly calculated
@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Jun 1, 2023
@themarolt themarolt changed the title Fixing a few issues Fixing a few issues with unleash and new services Jun 1, 2023
@gaspergrom gaspergrom self-requested a review June 1, 2023 07:36
@themarolt themarolt merged commit 6dfdf1c into main Jun 1, 2023
@themarolt themarolt deleted the bugfix/feature-flags-issues branch June 1, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants