Merged
Conversation
garrrikkotua
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 0e1eeb0
This pull request introduces custom path aliases for the TypeScript code of three services:
integration_data_worker,integration_run_worker, andintegration_stream_worker. It adds thetsconfig-pathsdependency and modifies thepackage.jsonandtsconfig.jsonfiles of each service to enable path resolution at runtime and compile time. It also renames theconfigfolders toconfin each service to avoid confusion with theconfigmodule and updates the import statements accordingly. Additionally, it reorders some import statements alphabetically in theintegration_run_workerservice.
🤖 Generated by Copilot at 0e1eeb0
Why
How
🤖 Generated by Copilot at 0e1eeb0
tsconfig-pathsdependency to enable custom path aliases in TypeScript configuration files (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)startandstart:debugscripts to usetsconfig-paths/registermodule inpackage.jsonfiles ofintegration_data_worker,integration_run_worker, andintegration_stream_workerservices (link, link, link)configfolder toconfinintegration_data_worker,integration_run_worker, andintegration_stream_workerservices to avoid confusion withconfigmodule (link, link, link)configfolder toconfinmain.tsfiles ofintegration_data_worker,integration_run_worker, andintegration_stream_workerservices (link, link, link)@/alias forconffolder inintegrationDataService.ts,integrationRunService.ts, andintegrationStreamService.tsfiles ofintegration_data_worker,integration_run_worker, andintegration_stream_workerservices (link, link, link, link)esModuleInteropoption and setbaseUrlto./srcand define@/alias forconffolder inintegration_data_worker,integration_run_worker, andintegration_stream_workerservices (link, link, link)integrationRun.data.tsfile ofintegration_run_workerservice to follow alphabetical order of imported modules (link)Checklist ✅
Feature,Improvement, orBug.Add screehshots to the PR description for relevant FE changesNew backend functionality has been unit-tested.API documentation has been updated (if necessary) (see docs on API documentation).