Check null sentiments when calculating average sentiment#943
Merged
Conversation
themarolt
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 09ec5c1
Fixed a potential bug in
memberRepository.tsthat could cause an error when calculating the sentiment score of a member. Added a null check fori.sentimentbefore accessing itssentimentproperty.
🤖 Generated by Copilot at 09ec5c1
Why
How
🤖 Generated by Copilot at 09ec5c1
i.sentimentbefore accessing itssentimentproperty to avoid errors when calculating the average sentiment score of a member's activities (link) inmemberRepository.tsChecklist ✅
Feature,Improvement, orBug.