Add GitHub OAuth authentication support#983
Merged
skwowet merged 23 commits intolinuxfoundation:mainfrom Jul 10, 2023
Merged
Conversation
Collaborator
Author
|
Extremely sorry for the delay guys, I have been AFK for quite some time, due to my exams 🙂 |
Contributor
Collaborator
Author
|
Hey @nunoeufrasio! 👋 Thanks for the design suggestion. I actually had the same thought because when I visually compare the GitHub logo to Google's, it doesn't seem big enough. But when I increase the width and height, the logo doesn't actually get bigger, it just takes up more space. It's a bit puzzling, isn't it? 🤔
|
Collaborator
Author
|
I have introduced a new |
epipav
requested changes
Jul 10, 2023
Collaborator
epipav
left a comment
There was a problem hiding this comment.
nice work 💪 I made some comments regarding code structure
joanagmaia
approved these changes
Jul 10, 2023
epipav
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes proposed ✍️
What
🤖 Generated by Copilot at ce82a79
Added GitHub OAuth integration to the backend and frontend of the application. This allows users to sign in or sign up with their GitHub accounts using
authSocial.ts,signin-page.vue, andsignup-page.vue.
🤖 Generated by Copilot at ce82a79
Why
Most devs are probably more likely to be logged into GitHub than Google, as mentioned in issue #444 🛠️
Screenshots
Here's how it looks on the signup and login page,
How
🤖 Generated by Copilot at ce82a79
GITHUB_CONFIGfrom../../conf(link) and adding two routes to handle the authorization and callback (link) inbackend/src/api/auth/authSocial.ts.Checklist ✅
Feature,Improvement, orBug.