refactor(workflows): cleanup data-capture tasks#2016
Merged
toubatbrian merged 1 commit intoJul 10, 2026
Conversation
…asks Follow-up to the built-in workflow port (#2007), applying reviewer feedback before the feature ships: - Drop the deprecated `extraInstructions` option from GetEmailTask and GetAddressTask. It was a `# deprecated` field in the Python source; a brand-new JS API shouldn't inherit deprecated surface. Callers use `instructions.extra` (InstructionParts). The non-deprecated `extraInstructions` on name/phone/dob/credit-card tasks is kept. - camelCase all LLM-facing tool argument names to match JS conventions: street_address -> streetAddress, unit_number -> unitNumber, first_name/middle_name/last_name -> firstName/middleName/lastName, card_number -> cardNumber, security_code -> securityCode, expiration_month/year -> expirationMonth/Year, phone_number -> phoneNumber, and the repeated_* confirmation args. GetNameTask's nameFormat placeholders and all internal instruction-template placeholders are camelCased to match. - Remove the pythonic `kwargs` bag from resolveWorkflowInstructions in favour of explicit `modalitySpecific` / `confirmation` params. - Drop the `| null` option types and the resulting `x ?? undefined` pass-through noise at AgentTask.create call sites; optional params are plain `?:` now. Behavior is unchanged; these are API-surface and internal-plumbing cleanups on code that has not shipped yet. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3ZnFWr54AZysyyf4g5Dyd
|
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
toubatbrian
changed the title
theomonnom
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #2007 (built-in data-capture workflow port). All changes are API-surface / internal-plumbing cleanups on code that has not shipped yet — behavior is unchanged.
Changes Made
extraInstructionsfromGetEmailTaskandGetAddressTask. It was a# deprecatedfield in the Python source; a brand-new JS API shouldn't inherit deprecated surface. Those two tasks takeinstructions.extraviaInstructionPartsinstead. (The non-deprecatedextraInstructionson name/phone/dob/credit-card tasks — a real parameter in Python — is kept.)street_address→streetAddress,unit_number→unitNumberfirst_name/middle_name/last_name→firstName/middleName/lastNamecard_number→cardNumber,security_code→securityCode,expiration_month/expiration_year→expirationMonth/expirationYear,phone_number→phoneNumberrepeated_*confirmation args likewiseGetNameTask'snameFormatplaceholders ({first_name}→{firstName}) and every internal instruction-template placeholder are camelCased to matchkwargsbag fromresolveWorkflowInstructionsin favour of explicitmodalitySpecific/confirmationparams.| nulloption types and the resultingx ?? undefinedpass-through noise atAgentTask.createcall sites; optional params are plain?:now.Left as-is per reviewer: the
onEnterabort-signal suggestion forGetDtmfTask(auto-cancelling theroom.on/state listeners and the debounced reply) is deferred to a later change.Pre-Review Checklist
pnpm build:agents,pnpm lint(workflows),pnpm format:checkgreenagents/src/workflows/*Testing
pnpm build:agentsgreen; ESLint + Prettier clean onagents/src/workflows/agent.test.ts,chat_context.test.ts) passAdditional Notes
No new changeset — this refines the same unreleased workflows feature already covered by
port-builtin-workflows.mdon the base branch.