fix(voice): harden input detach mute - #2232
Merged
Merged
Conversation
After #2222, flip ParticipantAudioInputStream gate state via setAttached before onAttached/onDetached so lifecycle overrides cannot skip mute. Also include agent_false_interruption in SessionHost forwarded-event coverage to unblock CI. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 8d15dd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
toubatbrian
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
theomonnom
approved these changes
Aug 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentInputnow callsAudioInput.setAttached()beforeonAttached/onDetachedParticipantAudioInputStreamgates onsetAttachedso hook overrides that omit attach-state updates still muteRecorderAudioInputforwardssetAttachedto its sourceagent_false_interruptiontoFORWARDED_EVENTSinremote_session.test.ts(main drift from voice: forward agent_false_interruption over the RemoteSession #2214, unrelated to mute but blocked Fix room audio input detachment #2222 CI)Test plan
pnpm exec vitest run --project nodejs agents/src/voice/io.test.ts agents/src/voice/room_io/_input.test.ts agents/src/voice/remote_session.test.ts agents/src/voice/recorder_io/recorder_io.test.tsCloses duplicate work from #2231.