fix(gradium): update parameters - #2359
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: c8b41ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports livekit/agents#7014 to the Gradium TypeScript plugin.
4SZHfMpw-p46Ywgs) as the default TTS voiceTTS.updateOptions()to updatevoiceId@livekit/agents-plugin-gradiumThe source PR adds or modifies no tests.
Source diff coverage
File-by-file classification
livekit-plugins/livekit-plugins-gradium/livekit/plugins/gradium/__init__.py->plugins/gradium/src/index.ts. The target already uses explicit named exports and does not exportLLM, so the phantom-export fix is already satisfied without an edit.livekit-plugins/livekit-plugins-gradium/livekit/plugins/gradium/stt.py->plugins/gradium/src/stt.ts. The target already resolvesmodelEndpointin the same order: explicit option,GRADIUM_MODEL_ENDPOINT, then the hosted ASR endpoint. The removed Python-only TODO has no target counterpart, so no edit is needed.livekit-plugins/livekit-plugins-gradium/livekit/plugins/gradium/tts.py->plugins/gradium/src/tts.ts. Updated the default voice ID to Harper and addedvoiceIdto the options accepted byupdateOptions; endpoint precedence was already equivalent in the target.Verification
pnpm exec vitest run plugins/gradium --passWithNoTests(passes; the package currently has no test files)pnpm buildpnpm lintpnpm exec prettier --check "plugins/gradium/src/tts.ts" ".changeset/quiet-dodos-smile.md"pnpm testattempted after build: 1,361 tests pass; unrelated existing/environmental failures remain in AMD, OpenAI/Cerebras setup, an example LLM assertion, Hugging Face download timeout, Silero fixture setup, and worker cleanup.Authoritative source: livekit/agents#7014
Ported from livekit/agents#7014
Original PR description