fix: avoid dual package hazard by building single CJS version that's … - #700
Merged
Conversation
🦋 Changeset detectedLatest commit: 12a2fc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
requested review from
1egoman,
chenghao-mou,
toubatbrian and
xianshijing-lk
July 27, 2026 09:13
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chenghao-mou
approved these changes
Jul 27, 2026
… into lukas/single-cjs-build
1egoman
approved these changes
Jul 27, 2026
1egoman
left a comment
1egoman
left a comment
Contributor
There was a problem hiding this comment.
Talked about this with lukas in a 1:1, generally makes sense. However, I think it would be ideal if it could be the other way (ie, wrap the esm version and expose as commonjs) since the majority of users should be using esm these days. If that is overly burdensome / challenging, then what is here is fine.
toubatbrian
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…wrapped for ESM