-
Notifications
You must be signed in to change notification settings - Fork 112
fix: avoid dual package hazard by building single CJS version that's … #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+45
−4
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8d47d7c
fix: avoid dual package hazard by building single CJS version that's …
lukasIO a85a3b7
Update postbuild.mjs
lukasIO caca2da
Update CJS build to include ESM wrapper
lukasIO dd09c3a
Update tsup.config.ts
lukasIO 50fff9a
assert package artefact equality
lukasIO 389fd1b
Merge branch 'lukas/single-cjs-build' of github.com:livekit/node-sdks…
lukasIO 6d268e4
reuse
lukasIO a4bf997
Merge branch 'main' into lukas/single-cjs-build
lukasIO 12a2fc4
use cts for default types
lukasIO File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@livekit/rtc-node": patch | ||
| --- | ||
|
|
||
| fix: avoid dual package hazard by building single CJS version with an ESM wrapper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // SPDX-FileCopyrightText: 2026 LiveKit, Inc. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import assert from 'node:assert/strict'; | ||
| import { createRequire } from 'node:module'; | ||
| import * as esm from '../dist/index.js'; | ||
|
|
||
| const require = createRequire(import.meta.url); | ||
| const cjs = require('../dist/index.cjs'); | ||
|
|
||
| assert.equal(esm.Room, cjs.Room); | ||
| assert.equal(esm.AudioFrame, cjs.AudioFrame); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // SPDX-FileCopyrightText: 2026 LiveKit, Inc. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // Runs after `tsup` (which emits the single CJS build + `.d.cts` declarations). | ||
| // | ||
| // 1. Emit the ESM-facing `.d.ts` declarations via tsc (tsup only produces the | ||
| // `.d.cts` files for the `require` condition). | ||
| // 2. Write the ESM entry point as a thin wrapper that re-exports the single CJS | ||
| // build. esbuild emits a cjs-module-lexer-friendly `module.exports` marker, | ||
| // so Node's ESM loader statically resolves every named export from | ||
| // `index.cjs` and `export *` needs no per-export maintenance. | ||
| // | ||
| // Keeping a single physical implementation (index.cjs) means `import` and | ||
| // `require` share one module instance, avoiding the dual-package hazard. | ||
| import { execSync } from 'node:child_process'; | ||
| import { writeFileSync } from 'node:fs'; | ||
|
|
||
| execSync('tsc --declaration --emitDeclarationOnly', { stdio: 'inherit' }); | ||
|
|
||
| writeFileSync(new URL('../dist/index.js', import.meta.url), "export * from './index.cjs';\n"); | ||
|
|
||
| await import('./assertPackageEquality.mjs'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.