Fix toggle interactions - #2738
Merged
Merged
Conversation
ganyicz
marked this pull request as draft
August 14, 2026 12:46
ganyicz
marked this pull request as ready for review
August 14, 2026 13:06
Contributor
|
amazing. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
The toggle shows selection cursor and allows text selection, which is inconsistent with button
Additionally, clicking the toggle repeatedly causes zoom on mobile
Screen.Recording.2026-08-14.at.15.00.14.mov
The problem
HTML button displays the default cursor and prevents selection / zoom by default.
The toggle is composed of
ui-switchwhich does not have these properties.The solution
Add
select-noneandtouch-manipulationclasses to mimic button behavior.