Add -webkit-user-select: none - #2745
Merged
Merged
Conversation
Contributor
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: calebporzio <3670578+calebporzio@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Safari doesn't support
user-select: nonewithout a-webkitprefix.In #2738 we had to add
select-noneclass to force the default cursor on toggle, despite theui-switchalready applyinguser-select: nonein the default css rules. The reason was that the bug was limited to Safari. Because theselect-nonetailwind class applies the rule with the webkit prefix, this fixed the issue. However the fix really belongs to the css file.The solution
-webkit-user-select: noneto all default CSS rules where we haveuser-select: noneselect-nonefrom toggle