[Sim] Set the GetFileOp operation to procedural only#10474
Merged
fzi-hielscher merged 2 commits intoMay 15, 2026
Conversation
nanjo712
force-pushed
the
refactor/make-getfileOp-proceduralOp
branch
2 times, most recently
from
87ca790 to
8d6359e
Compare
nanjo712
force-pushed
the
refactor/make-getfileOp-proceduralOp
branch
from
8d6359e to
169cbbd
Compare
nanjo712
commented
May 15, 2026
Comment on lines
+758
to
+762
| auto *procRoot = | ||
| getFileOp->getParentWithTrait<mlir::OpTrait::IsIsolatedFromAbove>(); | ||
| if (procRoot) | ||
| dceRoots.insert(procRoot); | ||
| getFileOp.erase(); |
Contributor
Author
There was a problem hiding this comment.
We could perhaps replace it with SparseOpSCC like #10469 . However, this isn't really relevant to this PR, so I prefer to keep the cleanup logic the same as the handling of printOp.
nanjo712
commented
May 15, 2026
| %file = sim.get_file %fileName | ||
|
|
||
| sim.print %msg on %clk if %cond to %file | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Since the GetFileOp is marked as ProceduralOp, I think these test is no longer needed. We may need to clean the logic about GetFileOp in ProceduralizeSim in the follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the GetFileOp operation to procedural only.