Skip to content

docs: require English for all repository artifacts - #865

Merged
grunch merged 1 commit into
mainfrom
docs/english-only-convention
Jul 7, 2026
Merged

docs: require English for all repository artifacts#865
grunch merged 1 commit into
mainfrom
docs/english-only-convention

Conversation

@grunch

@grunch grunch commented Jul 7, 2026

Copy link
Copy Markdown
Member

What

Makes the English-only convention explicit so any contributor — human or coding agent — picks it up automatically.

  • AGENTS.md: new ## Language section stating that all repository artifacts (source code, comments, identifiers, commit messages, PR titles/descriptions, issues, docs) must be written in English, regardless of the language used to converse with a contributor.
  • CLAUDE.md: a one-line pointer under a ## Conventions heading, since Claude Code auto-loads this file.

Why

The rule was implicit. AGENTS.md is the tool-agnostic guidelines file most coding agents read, so it is the canonical home; CLAUDE.md mirrors a short pointer to guarantee coverage for Claude Code sessions whether or not AGENTS.md is loaded.

Docs-only change: no runtime, build, or test impact.

🤖 Generated with Claude Code

https://claude.ai/code/session_01X5uNqd26cC88p5HVqErRDU


Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified repository language guidelines to require English for code, comments, identifiers, commit messages, pull requests, issues, and documentation.
    • Added a related note in project guidance to keep these conventions consistent across repository content.

Make the English-only convention explicit so any contributor or coding
agent picks it up. Add a Language section to AGENTS.md (the tool-agnostic
guidelines file) and mirror a one-line pointer in CLAUDE.md (auto-loaded
by Claude Code), covering code, comments, identifiers, commit messages,
PR titles/descriptions, issues and docs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X5uNqd26cC88p5HVqErRDU
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR adds documentation-only changes requiring all repository content—code, comments, commit messages, PRs, issues, and docs—to be written in English. A new "Language" section is added to AGENTS.md, and a "Conventions" section referencing AGENTS.md is added to CLAUDE.md.

Changes

Documentation policy update

Layer / File(s) Summary
Add English-only content requirement
AGENTS.md, CLAUDE.md
New sections require all repository artifacts to be written in English, with CLAUDE.md referencing AGENTS.md for details.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • lnp2pBot/bot#690: Both PRs update repository contribution documentation to require/guide English usage.

Poem

A rabbit hops with quill in paw,
"Write it in English!" is now the law.
AGENTS and CLAUDE, both agree,
Words in one tongue, clear as can be.
🐇📜✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the docs-only change enforcing English across repository artifacts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/english-only-convention

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CLAUDE.md`:
- Line 7: The Markdown emphasis in CLAUDE.md uses bold asterisks in the
“Language” entry, which conflicts with the repo’s `.md` formatting rule. Update
that line to use underscore emphasis instead of asterisks, keeping the same
wording and locating it in the Language section near the top of the document.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a9c84944-f783-478c-a436-088eb32d73f0

📥 Commits

Reviewing files that changed from the base of the PR and between 7a49ae8 and 63e57d2.

📒 Files selected for processing (2)
  • AGENTS.md
  • CLAUDE.md

Comment thread CLAUDE.md

## Conventions

- **Language:** everything committed to this repo (code, comments, commit messages, PRs, issues, docs) must be in English. See AGENTS.md.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use underscores instead of bold asterisks here.

**Language:** violates the Markdown rule for .md files. As per coding guidelines, use underscores for emphasis (_text_) instead of asterisks (*text*).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CLAUDE.md` at line 7, The Markdown emphasis in CLAUDE.md uses bold asterisks
in the “Language” entry, which conflicts with the repo’s `.md` formatting rule.
Update that line to use underscore emphasis instead of asterisks, keeping the
same wording and locating it in the Language section near the top of the
document.

Source: Coding guidelines

@grunch
grunch merged commit e45b8ec into main Jul 7, 2026
7 checks passed
@grunch
grunch deleted the docs/english-only-convention branch July 7, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants