Implement overrides make overload resolution more explicit#211
Closed
bjornharrtell wants to merge 1 commit intolocationtech:masterfrom
Closed
Implement overrides make overload resolution more explicit#211bjornharrtell wants to merge 1 commit intolocationtech:masterfrom
bjornharrtell wants to merge 1 commit intolocationtech:masterfrom
Conversation
Signed-off-by: Björn Harrtell <bjorn@wololo.org>
Contributor
|
Since these changes introduce overhead which is not required by Java, it would be worth adding a comment to indicate that these are in place to support JSTS. Otherwise they might get "cleaned up" in a future release (and also alerts readers that there is a reason why standard Java practice is not being followed). |
Contributor
Author
|
Hmm didn't realize they cause overhead. Will see if I can find a solution on my end instead. |
Contributor
Author
|
Closing until further notice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to solve similar problems as in #213 but is less invasive, should not be breaking anything.