Rename coordinate edit method#213
Closed
bjornharrtell wants to merge 1 commit intolocationtech:masterfrom
Closed
Conversation
Signed-off-by: Björn Harrtell <bjorn@wololo.org>
Contributor
|
What about the overloaded edit method in CoordinateSequenceOperation? That should probably be renamed for consistency, if nothing else. |
Contributor
Author
|
Agreed, it looks a bit inconsistent. As mentioned, already a bit hesistant on this change in the first place.. and the rename is required only because the input is an array causing a hard time resolving the overload like in some previous cases. So, I will instead see if I can work out a solution to avoid this change. |
Contributor
Author
|
Closing until further notice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to solve a difficult overload situation that I haven't been able to solve in transpiling. It's a case of relying on inheritance and method overload at the same time.
As this is a breaking change so I understand if it's not acceptable. Wanted to suggest it anyway if it's known that this API is rarely used and could perhaps be changed.