Skip to content

chore(deployment): switch workflow telemetry action#6369

Merged
corneliusroemer merged 1 commit into
mainfrom
switch-workflow-telemetry-action
May 22, 2026
Merged

chore(deployment): switch workflow telemetry action#6369
corneliusroemer merged 1 commit into
mainfrom
switch-workflow-telemetry-action

Conversation

@corneliusroemer

@corneliusroemer corneliusroemer commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR switches the integration test workflow telemetry step from unmaintained and broken catchpoint/workflow-telemetry-action@v2 to the maintained fork ycfreeman/workflow-telemetry-action, pinned to commit cad169ff11f718319d5468b0a67a238db000ef3f.

The upstream Catchpoint action currently only publishes v2 / v2.0.0, which still uses the older Node runtime.

This action has been useful to see CPU/disk usage and timing of integration test workflow.

Testing

New action works and produces good results

Graphs look like this:

image

🚀 Preview: Add preview label to enable

@claude claude Bot added the deployment Code changes targetting the deployment infrastructure label May 8, 2026
@corneliusroemer corneliusroemer marked this pull request as ready for review May 8, 2026 09:44
Copilot AI review requested due to automatic review settings May 8, 2026 09:44
@claude

claude Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @corneliusroemer's task in 48s —— View job


Code Review

  • Gather context and read changed files
  • Analyze security implications of using a fork
  • Provide review feedback

This is a minimal, well-justified change. A few notes:

Security

Switching from @v2 (mutable tag) to a pinned commit SHA is a security improvement — it prevents tag-drift supply chain attacks. The main trust consideration is that ycfreeman is now a new trusted entity in the CI supply chain. Since this action runs before actions/checkout, it executes in a context with access to the runner environment and job tokens, so the fork author's trustworthiness matters. Worth verifying the fork is a genuine, unmodified copy of the upstream (or a minimal improvement) before merging.

Maintainability

The workflow file has no inline comment explaining why a fork is used. Future maintainers will see an unusual fork reference with a raw SHA and wonder why. A short comment like # fork of catchpoint/workflow-telemetry-action@v2 (unmaintained) above the step would save that confusion. Fix this →

Overall: Change looks good. Switching from an unmaintained action with old Node runtime to a pinned fork is the right call. Confirm the fork's provenance and optionally add a comment before merging.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Switches the integration-test workflow telemetry step from the unmaintained Catchpoint action to the maintained ycfreeman fork, while pinning to a specific commit for reproducibility/supply-chain safety.

Changes:

  • Replaced catchpoint/workflow-telemetry-action@v2 with ycfreeman/workflow-telemetry-action@cad169ff11f718319d5468b0a67a238db000ef3f in the integration tests workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@corneliusroemer corneliusroemer removed the deployment Code changes targetting the deployment infrastructure label May 8, 2026

@anna-parker anna-parker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like not blocking but this fork doesnt seem to be too used, just dont want us to switch to sth and have issues in the future: https://github.com/ycfreeman/workflow-telemetry-action

@corneliusroemer

corneliusroemer commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

this fork doesnt seem to be too used,

That's how forks start, someone takes over maintenance

have issues in the future

Not a problem, we can just disable/reevaluate then. It's not a big deal, but the action is helpful see for example #6370 where I use it to see what CPU load is.

@corneliusroemer

Copy link
Copy Markdown
Contributor Author

@anna-parker @theosanderson would be good to either replace (this PR) or remove the action (in another PR if you prefer) as it's just producing a lot of noise right now:

image

@corneliusroemer corneliusroemer merged commit 5da9cd7 into main May 22, 2026
58 checks passed
@corneliusroemer corneliusroemer deleted the switch-workflow-telemetry-action branch May 22, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants