Skip to content

fix(enable-spdk): extend check for IOMMU support (backport #582) - #590

Merged
derekbit merged 2 commits into
v1.13.xfrom
mergify/bp/v1.13.x/pr-582
Sep 5, 2026
Merged

fix(enable-spdk): extend check for IOMMU support (backport #582)#590
derekbit merged 2 commits into
v1.13.xfrom
mergify/bp/v1.13.x/pr-582

Conversation

@mergify

@mergify mergify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Which issue(s) this PR fixes:

Issue longhorn/longhorn#12076

What this PR does / why we need it:

Adds a check for IOMMU support to preflight --enable-spdk

Special notes for your reviewer:

Additional documentation or context


This is an automatic backport of pull request #582 done by [Mergify](https://mergify.com).

Signed-off-by: Apoorva Jagtap <apoorva.jagtap@suse.com>
(cherry picked from commit b67f109)
longhorn/longhorn#12076

Signed-off-by: Apoorva Jagtap <apoorva.jagtap@suse.com>
(cherry picked from commit 6e546b4)
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.82759% with 414 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.32%. Comparing base (e03bd2c) to head (e7bf389).

Files with missing lines Patch % Lines
...l/preflight/packagemanager/mocks/PackageManager.go 0.00% 413 Missing ⚠️
pkg/local/preflight/checker.go 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v1.13.x    #590      +/-   ##
==========================================
+ Coverage     3.14%   3.32%   +0.18%     
==========================================
  Files           42      43       +1     
  Lines         3629    4064     +435     
==========================================
+ Hits           114     135      +21     
- Misses        3512    3926     +414     
  Partials         3       3              
Flag Coverage Δ
unittests 3.32% <4.82%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify

mergify Bot commented Sep 4, 2026

Copy link
Copy Markdown
Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify

mergify Bot commented Sep 4, 2026

Copy link
Copy Markdown
Author

queue

⚠️ Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

@derekbit
derekbit merged commit 0dd024c into v1.13.x Sep 5, 2026
9 checks passed
@derekbit
derekbit deleted the mergify/bp/v1.13.x/pr-582 branch September 5, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants