Skip to content

Test against Ruby 2.2 and JRuby 2.0/2.1 modes#464

Closed
O-I wants to merge 6 commits into
lostisland:masterfrom
O-I:update-travis
Closed

Test against Ruby 2.2 and JRuby 2.0/2.1 modes#464
O-I wants to merge 6 commits into
lostisland:masterfrom
O-I:update-travis

Conversation

@O-I
Copy link
Copy Markdown
Contributor

@O-I O-I commented Feb 1, 2015

Hi.

This attempts to move issues #348 and #374 forward. I've added JRuby 2.0 and 2.1 modes to the Travis build and allow them to fail. I've also added MRI 2.2 to see if it passes.

Cheers,
O-I

@O-I
Copy link
Copy Markdown
Contributor Author

O-I commented Feb 1, 2015

Ruby 2.2 fails with this error. I've removed it from .travis.yml for now. Not too confident I can troubleshoot that alone. I can explore. Or someone with more experience can enlighten me at their convenience. 😃

@mislav
Copy link
Copy Markdown
Contributor

mislav commented Feb 2, 2015

It seems that old Typheus fails to compile on Ruby 2.2. You could put back 2.2 on the CI list but figure out how to skip the old Typhoeus test. It's not crucial.

@O-I
Copy link
Copy Markdown
Contributor Author

O-I commented Feb 2, 2015

OK. So I think I figured out how to skip the Typhoeus tests on Ruby 2.2 and get it passing on Travis, but now I've hit some sort of SSL(?) error on Ruby 2.1.

Comment thread test/helper.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should do RUBY_VERSION > '2.2' and you don't need any RUBY_ENGINE checks. We want this method to return true for every version from 2.2.0 forward. We don't want Typhoeus tests run on 2.3.

@mislav
Copy link
Copy Markdown
Contributor

mislav commented Feb 3, 2015

Intermittent failure. We sometimes get those. Restarted and the build passed.

@O-I
Copy link
Copy Markdown
Contributor Author

O-I commented Feb 3, 2015

Wow. Plain old string comparison really makes that method clear. Anything else?

@mislav mislav closed this in 81f1659 Feb 4, 2015
@mislav
Copy link
Copy Markdown
Contributor

mislav commented Feb 4, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants