[bazel] Use in-tree openssl for Rust openssl-sys#30706
Merged
Merged
Conversation
pamaury
reviewed
Jul 10, 2026
| repositories = ["crate_index"], | ||
| ) | ||
|
|
||
| inject_repo(crate, "openssl") |
Contributor
There was a problem hiding this comment.
The openssl name is a bit generic, especially for the crate extension which handles a lot of thing. I would suggest to inject_repo(crate, ot_openssl="openssl") just to be sure.
Also, do you really need to inject the repository? I would have expected that the point of having a build_script_data attribute is to avoid this kind of hacks.
Contributor
Author
There was a problem hiding this comment.
Thank, update with ot_openssl="openssl".
Without inject_repo, bazel can't resolve the openssl repo referrenced in build_script_data.
ERROR: no such package '@@[unknown repo 'openssl' requested from @@rules_rust++crate+crate_index__openssl-sys-0.9.102]//':
The repository '@@[unknown repo 'openssl' requested from @@rules_rust++crate+crate_index__openssl-sys-0.9.102]' could not be resolved:
No repository visible as '@openssl' from repository '@@rules_rust++crate+crate_index__openssl-sys-0.9.102'
pamaury
reviewed
Jul 10, 2026
sasdf
force-pushed
the
mjTktoxolxx
branch
2 times, most recently
from
ff4df87 to
736b5e1
Compare
Add `--host_jvm_args=-Xmx8g` to the default `BAZELISK` command in `prep-bazel-airgapped-build.sh` to prevent JVM out-of-memory errors during the airgapped prep. Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com> Change-Id: Ie8d4ff2990ba18307c3165b0aaf1ff006a6a6964
Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com> Change-Id: If6b2be221d2330cbe42062f8cd061da26a6a6964
luismarques
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #30621 brings newer openssl in-tree, and this PR utilize this openssl for the rust binding.
This change allows ml-dsa cert verification which requires newer openssl.