[dv] Add cov related targets in Makefile and coverage exclusion file by weicaiyang · Pull Request #635 · lowRISC/opentitan

weicaiyang · 2019-10-25T20:44:42Z

add coverage review command and common coverage exclusion file
2 add uart coverage exclusion file

weicaiyang · 2019-10-25T20:49:48Z

@cindychip @gaurangchitroda @shakushw
Once this PR is merged, you can use make cov_review to open verdi to review and generate coverage report. Common coverage exclusion file will be included.
Also add your IP specific exclusion file in IP Makefile.

weicaiyang · 2019-10-25T20:51:10Z

@eunchan Please help to review those 2 exclusion files ending with *.el. I have added rational for each exclusion.

sriyerg · 2019-10-25T22:41:39Z

Use ${BUILD_DIR} here instead.

sriyerg · 2019-10-25T22:42:19Z

cov_analyze is probably better.

Should we add cov_report as well (that runs the urg command)?

updated the name.
add cov_report but urg opts is slightly different

sriyerg · 2019-10-25T22:43:17Z

Can you update the uvmdvgen script to create this directory as well?

sriyerg · 2019-10-25T22:45:20Z

COV_EXCL += $(COMMON_COV_EXCL)

sriyerg · 2019-10-25T22:47:13Z

Should we add cov_report as well (that runs the urg command)?

sriyerg · 2019-10-26T00:19:35Z

I think better to not add this file, just create the dir (xcelium format will be different - this assumes vcs).

sriyerg · 2019-10-26T00:21:46Z

Move these to after 'run_result` and a new add section

############################## ## Coverage related targets ## ##############################

sriyerg · 2019-10-26T00:24:40Z

change IP-> DUT

sriyerg · 2019-10-26T00:27:38Z

make this:

('dv/cov', '', '', ''),

On line 53 add

if fname == "": continue

Updated. PTAL

1. add coverage review command and common coverage exclusion file 2 add uart coverage exclusion file

weicaiyang · 2019-10-28T18:05:11Z

@eunchan Please help to review those 2 exclusion files ending with *.el

eunchan · 2019-10-28T18:27:10Z

On Mon, Oct 28, 2019 at 11:05:16AM -0700, weicaiyang wrote: @eunchan Please help to review those 2 exclusion files ending with *.el

Looks good. One thing for `scanmode` is... UART IP will have `scanmode_i` from the top after PR #615 is merged. One TODO in uart.sv was related to this.

weicaiyang · 2019-10-28T20:07:08Z

Looks good. One thing for scanmode is... UART IP will have scanmode_i from the top after PR #615 is merged. One TODO in uart.sv was related to this.

Thanks for the heads-up. Will update it later.

weicaiyang requested review from cindychip, gaurangchitroda, shakushw and sriyerg October 25, 2019 20:44

weicaiyang requested a review from eunchan October 25, 2019 20:49

sriyerg reviewed Oct 25, 2019

View reviewed changes

Comment thread hw/dv/tools/vcs/vcs.mk Outdated

Copy link
Copy Markdown

Contributor

sriyerg Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ${BUILD_DIR} here instead.

sriyerg reviewed Oct 25, 2019

View reviewed changes

weicaiyang requested a review from sriyerg October 25, 2019 23:43

sriyerg reviewed Oct 26, 2019

View reviewed changes

Comment thread hw/ip/uart/dv/Makefile Outdated

Copy link
Copy Markdown

Contributor

sriyerg Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change IP-> DUT

sriyerg reviewed Oct 26, 2019

View reviewed changes

[dv] Add cov_review in Makefile and coverage exclusion file

b04c4f1

1. add coverage review command and common coverage exclusion file 2 add uart coverage exclusion file

weicaiyang requested a review from sriyerg October 26, 2019 01:11

sriyerg approved these changes Oct 26, 2019

View reviewed changes

weicaiyang changed the title ~~[dv] Add cov_review in Makefile and coverage exclusion file~~ [dv] Add cov related targets in Makefile and coverage exclusion file Oct 26, 2019

weicaiyang merged commit 9dff09b into lowRISC:master Oct 26, 2019

weicaiyang deleted the add_cov_el branch October 26, 2019 01:34

Conversation

weicaiyang commented Oct 25, 2019

Uh oh!

weicaiyang commented Oct 25, 2019

Uh oh!

weicaiyang commented Oct 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sriyerg Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sriyerg Oct 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weicaiyang commented Oct 28, 2019

Uh oh!

eunchan commented Oct 28, 2019 via email

Uh oh!

weicaiyang commented Oct 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sriyerg Oct 25, 2019 •

edited

Loading

sriyerg Oct 26, 2019 •

edited

Loading