docs: fix grammatical and logical bugs in VerilogCodingStyle.md#92
Open
mondalsushant wants to merge 2 commits into
Open
docs: fix grammatical and logical bugs in VerilogCodingStyle.md#92mondalsushant wants to merge 2 commits into
mondalsushant wants to merge 2 commits into
Conversation
Author
|
Hi @rswarbrick and @marnovandermaas, The changes are ready for inspection. Whenever you have some time, could you please take a look and review this PR? Thank you! |
Author
|
@rswarbrick can you please have a look at this since I saw you are online. Thanks! |
rswarbrick
reviewed
Jul 2, 2026
| The preferred naming convention for all immutable constants is to use `ALL_CAPS`, but there are times when the use of `UpperCamelCase` might be considered more natural. | ||
|
|
||
| | Constant Type | Style Preference | Conversation | | ||
| | Constant Type | Style Preference | Convention | |
Contributor
There was a problem hiding this comment.
I agree that "Conversation" is a slightly weird heading here, but I don't think that "Convention" is the right fix. How about "Reason" or "Justification"?
Author
There was a problem hiding this comment.
"Reason" might be better than "Justification", right? Because "Justification" tries to "defend" something, whereas "Reason" is neutral, fits into the context, and is short too. What's your say?
Note: A new PR is required for "2012" -> "2017" as per the reviewer.
mondalsushant
force-pushed
the
fix/grammatical-and-logical-bugs
branch
from
9a6630c to
144c302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
end.->end.