Conversation
lstocchi
force-pushed
the
i25038
branch
7 times, most recently
from
829ff8f to
13e53b2
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
Added a way to define default runtime flags in config. Fixes: https://github.com/containers/common/issues/715 Default runtime flags should be defined as shown below: [engine.runtimes_flags] runsc = [ "net-raw", ] crun = [ "debug", ] Signed-off-by: Rosvaldas Atstupėnas <atstupenas.rosvaldas@gmail.com>
Resolves: containers#27268 Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
Problem: While removing cgroupsv1 code, I noticed my neovim Go config automatically changed fileperms to the new octal format and I didn't want that polluting my diffs. Decision: I thought it best to switch to the new octal format in a dedicated PR. Action: - Cursor switched to new octal format for all fileperm ocurrences in Go source and test files. - vendor/, docs/ and non-Go files were ignored. - Reviewed manually. Ref: https://go.dev/ref/spec#Go_1.13 Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Fixes: containers#27277 Signed-off-by: Martin Fischer <martin@push-f.com>
Allow artifact add to override org.opencontainers.image.title annotation
Signed-off-by: Matt Heon <mheon@redhat.com>
fileperms: newer Go 1.13+ octal literal format
…efile Quadlet build - add support for IgnoreFile key
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Fixes: containers#27314 Signed-off-by: Volodymyr Pankin <volopank@gmail.com>
Add support for runtime flags in containers.conf
…first-draft Add a new Windows installer supporting both user and machine scopes
Fixes: https://issues.redhat.com/browse/RUN-3578 Signed-off-by: Nicola Sella <nsella@redhat.com>
Fix regression in podman machine ssh
image got converted to the new docker modules which were finally renamed to moby[1]. Podman however still uses docker so now the swagger lookup seems to find duplicated types which in general breaks the generation so exclude the new module for now until we convert podman and fix the new type issues swagger found. [1] containers/container-libs#459 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This reverts commit 2b848cc. The official Docker API documentation was misleading here. Testing shown that old podman behaviour was correct. In docker copyUIDGID=true means that primary container uid/gid is used, not the uid/gid from the tar stream. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Remove hardcoded refs from ociartifact code
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-inversion Revert "Fix copyUIDGID parameter inversion in Docker compat API"
…om-godbus-dbus-v5-5.x fix(deps): update module github.com/godbus/dbus/v5 to v5.2.0
Podman6: Remove cgroupsv1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Quadlets installed from `.quadlet` file now belongs to a single application, anyone file removed from this application removes all the other files as well. Assited by: claude-4-sonnet Signed-off-by: flouthoc <flouthoc.git@gmail.com>
…om-opencontainers-selinux-1.x fix(deps): update module github.com/opencontainers/selinux to v1.13.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…olang.org-grpc-1.x fix(deps): update module google.golang.org/grpc to v1.77.0
quadlet install: add support for multiple quadlets in a single file
Remove skip_if_rootless_cgroupsv1 call from quadlet tests since cgroupsv1 is deprecated and no longer needs special handling Signed-off-by: Jan Rodák <hony.com@seznam.cz>
test/system: remove deprecated cgroupsv1 skip check
Fixes: containers#26588 For use cases like HPC, where `podman exec` is called in rapid succession, the standard exec process can become a bottleneck due to container locking and database I/O for session tracking. This commit introduces a new `--no-session` flag to `podman exec`. When used, this flag invokes a new, lightweight backend implementation that: - Skips container locking, reducing lock contention - Bypasses the creation, tracking, and removal of exec sessions in the database - Executes the command directly and retrieves the exit code without persisting session state - Maintains consistency with regular exec for container lookup, TTY handling, and environment setup - Shares implementation with health check execution to avoid code duplication The implementation addresses all performance bottlenecks while preserving compatibility with existing exec functionality including --latest flag support and proper exit code handling. Changes include: - Add --no-session flag to cmd/podman/containers/exec.go - Implement lightweight execution path in libpod/container_exec.go - Ensure consistent container validation and environment setup - Add comprehensive exit code testing including signal handling (exit 137) - Optimize configuration to skip unnecessary exit command setup Signed-off-by: Ryan McCann <ryan_mccann@student.uml.edu> Signed-off-by: ryanmccann1024 <ryan_mccann@student.uml.edu>
When starting a machine and the user has not explicitly passed -u=true|false AND stdin is a not a tty, we should not prompt to update connections. Fixes: containers#27556 Signed-off-by: Brent Baude <bbaude@redhat.com>
fake images: windows hyperv
Ignore prompt if stdin not a tty on machine start
…-exec-no-session feat(exec): Add --no-session flag for improved performance
this commit moves the HasAdminRights func from the wsl package to a generic windows package as this could also be used by the HyperV provider. Signed-off-by: lstocchi <lstocchi@redhat.com>
Previously, each new HyperV Podman machine required creating new hvsock registry entries, necessitating administrator privileges. This change modifies the HyperV provider to reuse existing hvsock entries if found. This is possible due to Podman's current limitation of running only one HyperV machine at a time. As a result, administrator privileges are only needed for the first initial machine setup (when the registry is empty). Subsequent machines can be created by users in the "Hyper-V Administrators" group without being Admin. Hvsock entries are no longer deleted on each machine removal; cleanup is handled when the last machine gets removed. Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
if users have legacy VMs (podman machines having hvsock registry entries with the machineName field) when using podman with this patch, their Registry entries will never be deleted by the functions added in previous commits. This commit adds a helper func to clean the Registry when these legacy machines get removed Signed-off-by: lstocchi <lstocchi@redhat.com>
|
A friendly reminder that this PR had no activity for 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?