[MSH] Implement Wonder Man, Hollywood Hero - #15700
Open
Grath wants to merge 3 commits into
Open
Conversation
Also change "max activations per game" to always be accessed via a Get helper method, and allow Power-Up abilities to be activated more times
…han a random magic 1.
JayDi85
reviewed
Jul 20, 2026
| ).stream() | ||
| .map(p -> p.getAbilities(game)) | ||
| .flatMap(Collection::stream) | ||
| .filter(PowerUpAbility.PowerUpMoreAbility.class::isInstance) |
Member
There was a problem hiding this comment.
It must be implemented by replace effect, not fake ability. See example with any game events like DAMAGE_CAUSES_LIFE_LOSS.
So both getMaxActivationsPerGame and hasMoreActivationsThisTurn can use it. It's allow to make a shared game engine feature and support diff logic-calcs-combos with multiple effects.
GameEvent maxActivationsEvent = new GameEvent(
GameEvent.EventType.MAX_ACTIVATIONS,
playerId, ability, playerId, maxActivationsPerGame, false);
game.replaceEvent(maxActivationsEvent);
return maxActivationsEvent.getAmount();
Contributor
Author
There was a problem hiding this comment.
I tried doing this, and while I could get it to show the ability as usable multiple times it didn't actually allow it to be activated more than once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also change "max activations per game" to always be accessed via a Getter, and allow Power-Up abilities to be activated more times by overriding that Get method using the same design as Boast.