Sales order grid doesn't pull in missing sales

[edward-simpson]

Preconditions and environment

• Magento version 2.4.5-p1
• dev/grid/async_indexing set to 1
• at least 2 existing orders

Steps to reproduce

1. Sort sales_order_grid by updated_at oldest first
2. Delete the first row (so you are deleting the order with the oldest updated_at
3. Run the sales_grid_order_async_insert cron job

I'm aware this is unlikely to happen in real life, but we are unaware of exactly how this state occurred, potentially the cron got killed off before the older order was synced

Expected result

The deleted grid order should get re-created, allowing the order to be viewed in the admin panel sales grid section

Actual result

The deleted grid order does not get re-created, the order cannot be viewed in the admin panel sales grid section, leading admin panel users to believe the order does not exist.

Note: There is no issue if any other order is deleted from sales_order_grid DB table.

Additional information

The sales_order_grid entry doesn't get re-created because it does not match the conditions which trigger this:

• sales_order entry has an updated_at newer than the most recent sales_order_grid entry
• the sales_order entry has a newer updated_at than the equivalent entry in the sales_order_grid (this doesn't match because the sales_order_grid entry doesn't exist)

Workaround is to update the sales_order.updated_at to be more recent than the most recent sales_order_grid.updated_at value. This can be tricky as the cron runs every minute, you have to time it correctly and get the value right, as you risk updating it to a value which then stops newer orders getting pulled into the grid

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @edward-simpson. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ssx]

I'm fairly sure we're seeing this issue in a production site.

[SamJUK]

Can confirm this after updating a production site to M2.4.5-p1. Also affecting the sales_invoice_grid table too.
Also don't know exactly whats causing the newer entities to be processed first, but we are seeing quite a few issues, in excess of 20/30 a day.

Our current temporary solution is just to refresh the Grid pool for the missing orders via a cron
https://gist.github.com/SamJUK/965f61fcfcd149e05b9c78cdaadc9ae4

As a longer term solution we are experiment with reverting the code to the previous 2.4.3 version within Magento\Sales\Model\ResourceModel\Provider\Query\IdListBuilder

    public function afterBuild(IdListBuilder $subject, $result, string $mainTableName, string $gridTableName): Select
    {
        return $this->getConnection()
            ->select()
            ->from($mainTableName, [$mainTableName . '.entity_id'])
            ->joinLeft(
                [$gridTableName => $gridTableName],
                sprintf(
                    '%s.entity_id = %s.entity_id',
                    $mainTableName,
                    $gridTableName
                ),
                []
            )
            ->where($gridTableName . '.entity_id IS NULL');
    }

[ssx]

@SamJUK yeah - same here. The affected orders had no invoice in the grid either.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.
This issue is not reproducible if any other is deleted from sales_order_grid DB table. Issue only reproduced if oldest order is deleted and run sales_grid_order_async_insert cron job. Hence updating the description and confirming the issue.