Cache not invalidated after customer login — outdated content shown

[antoniocarboni]

Preconditions and environment

Magento version: 2.4.8+
PHP version: 8.3
Full Page Cache: [built-in]

Steps to reproduce

1. Enable all caches
2. Navigate some pages
3. Login as a customer
4. Navigate previously visited pages

Expected result

Dynamic elements related to the user’s state should be flushed from the cache (e.g., the header should only display the My Account dropdown).

Actual result

These pages (except for the one the customer is redirected to) display elements for guests, such as the login/register links in the header.
PS: This problem becomes more important with custom content related to the logger user state.

Additional information

Maybe is related to this issue?
#40007

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @antoniocarboni. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @antoniocarboni,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

The header displaying only the My Account dropdown.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[orlangur]

PS: This problem becomes more important with custom content related to the logger user state.

@antoniocarboni for custom content you should implement such logic by yourself, you can learn from how it is implemented for core page elements.

You can read more on this topic here https://developer.adobe.com/commerce/php/development/cache/page/private-content/

[antoniocarboni]

@orlangur if Magento fails to handle cache logic for a logged in user, it is not the fault of a third party modification as the problem is also on the core parts of Magento. Simply this bug affects any part that is related to user sessions, be it core or custom

[antoniocarboni]

Hi @antoniocarboni,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

The header displaying only the My Account dropdown.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

As I specified in the information, this problem occurs ONLY on pages previously visited before logging in and excluding the page where the redirect is done.
You can try to visit 3-4 pages, log in and then revisit them and verify the problem.
I have tested the problem several times with different demos and in a clean environment (2.4.8 and 2.4.8p1) and the problem always occurs.
It does not occur with 2.4.7

[antoniocarboni]

Anyway I applied a patch using this pull request and it seems to fix this issue.
Once this PR is merged I think this issue can be considered closed.