-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: Lib/FrontendComponent: OtherIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release
Description
This is a follow up to #1619 - the error was not fully fixed there.
You can see it in the code of the patch: Only if the file was not changed trough preprocessing, a symlink is created. If it was, still a copy is created and grunt watches the wrong files for changes.
Preconditions
- Magento 2.1.0
- Theme with preprocessed file, for example a custom
Magento_Theme/module.lesscontains
//@magento_import 'module/_collapsible_navigation.less';
Steps to reproduce
- Execute grunt watch
- Change the above module.less
- grunt watch does not detect the change
- ls reveals: in
pub/staticthere is a (modified) copy of the file, not a symlink.grunt watch -vreveals, onlypub/staticbut notappis watched.
Expected result
- Grunt should watch all file changes
Actual result
- Grunt does not watch changes to all files, because some files are not symlinks
MidnightDesign, markdavies, pserrer, aaronsturm, dersam and 5 moreandrew-aladev
Metadata
Metadata
Assignees
Labels
Area: Lib/FrontendComponent: OtherIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release