Skip to content

Conversation

@evgk
Copy link
Member

@evgk evgk commented Jul 13, 2017

Since a local fix was chosen in PR#9266, there is still an interface mismatch. Proposed fix addresses it.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Since a local fix was chosen in PR#9266, there is still an interface mismatch. Proposed fix addresses it.
@ishakhsuvarov ishakhsuvarov self-assigned this Jul 13, 2017
@ishakhsuvarov ishakhsuvarov added this to the July 2017 milestone Jul 13, 2017
@ihor-sviziev
Copy link
Contributor

I think implementation should return correct type, interface shouldn't be changed.

@ishakhsuvarov
Copy link
Contributor

@evgk I agree with @ihor-sviziev. Why would Qty be represented by a string?

@okorshenko okorshenko self-assigned this Jul 13, 2017
@okorshenko
Copy link
Contributor

Hi @evgk thank you for the fix. Unfortunately, we can not accept this change despite it defines real return type from the method. The issue is more complex. We don't have in place the proper conversion of MySQL types to PHP types. We are working on this right now and this will be addressed in 2.3.

@okorshenko okorshenko closed this Jul 13, 2017
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 23, 2025
…owers

[Support Tier-4 flowers] 11-20-2025 Regular delivery of bugfixes and improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants