Skip to content

Conversation

@yuchenacidgreen
Copy link

@yuchenacidgreen yuchenacidgreen commented Feb 11, 2019

…catalog search

  • Fix search results default sorting config, remove hard coded sort by 'relevance'

Description (*)

Fixed Issues (if relevant)

  1. Changing sort order in admin doesn't work for catalog search #5730: Changing sort order in admin doesn't work for catalog search

Manual testing scenarios (*)

  1. Login to magento store admin
  2. Navigate to Stores->Configuration->Catalog->Catalog->Storefront
  3. Change Product Listing Sort by to Price
  4. Goto magento store frontend and search by keyword

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…earch

- Fix search results default sorting config, remove hard coded sort by 'relevance'
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 11, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @yuchenacidgreen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

@yuchenacidgreen thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@dmytro-ch dmytro-ch self-requested a review February 11, 2019 10:11
@dmytro-ch dmytro-ch self-assigned this Feb 11, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21119.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: Acidgreen labels Feb 15, 2019
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yuchenacidgreen thanks for the pull request.

I don't think that
Stores->Configuration->Catalog->Catalog->Storefront->Product Listing Sort by setting was designed to set the sort order for search results. Also, there is no way to provide sorting by relevance once the hardcoded sorting is removed.

What do you think about implementing a configuration entry specifically for search results sorting that will include relevance as an option?

@sidolov
Copy link
Contributor

sidolov commented Mar 14, 2019

@yuchenacidgreen , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Mar 14, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @yuchenacidgreen, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants