Fix the compatibility issue introduced by the change of catalog product view layout.

[Hailong]

Description (*)

Layout change of the Magento_Catalog::catalog_product_view.xml breaks legacy templates in which uses the $block->getProduct() function calls. Problem is the new introduced block class doesn't support this.

To avoid incompatibility problem. it's better to have the new class extends from the legacy class.

Fixed Issues (if relevant)

1. $block->getProduct() in catalog product view template failed after upgrading from 2.3.0 to 2.3.1 #22036: $block->getProduct() in catalog product view template failed after upgrading from 2.3.0 to 2.3.1

Manual testing scenarios (*)

1. Install Magento 2.3.0.
2. Install Porto Theme
3. Product page is broken.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[rogyar]

Agree. The existing templates that invoke getProduct() of the block might be broken.
Thank you!

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4605 has been created to process this Pull Request

[magento-engcom-team]

@Hailong thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[soleksii]

✔️ QA Passed

[sivaschenko]

Hi @Hailong @rogyar I have a concern about the backward incompatibility of this backward compatibility fix.

The backward incompatible difference between 2.3.1 and 2.3.2 version of the class is going to be 1 introduced a public method and more importantly 2 required constructor parameters.

[rogyar]

@sivaschenko. Agree. We need to choose between two evils here:

• Fix backward incompatible changes introduced in 2.3.1 (fix is fair in case of 2.3.0->2.3.1 upgrade)
• Leave backward incompatible changes introduced in 2.3.1 and don't introduce new potentially backward incompatible changes in 2.3.2.

After some consideration, I prefer the second option.

[sivaschenko]

Closing the pull request considering the discussion above. Feel free to contact me in case of any questions or comments

[m2-assistant]

Hi @Hailong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[Hailong]

Agree! Just for information of any others who are using Porto theme with Magento 2.3.1, Porto theme has published a newer version which has a fix for this problem.

[Seb33300]

@Hailong Where did you find the fixed version of Porto? I am encountering the same issue with the latest version 3.1.8 downloaded on themeforest

[Hailong]

@Seb33300 My theme was also 3.1.8 downloaded from ThemeForest. I just downloaded it again and checked it for you. The fixed file is in zip named Patch for Magento 2.3.1 And Above.zip, and its name is details.phtml

[Hailong]

@Seb33300 BTW, don't forget to unzip all the 'Patch...' zip files, and merge them into the theme. I don't like this either, but this is how Porto releases their new versions.