Skip to content

Fix for php 8.2#36901

Draft
rogerdz wants to merge 2 commits intomagento:2.4-developfrom
rogerdz:fix-php-8.2
Draft

Fix for php 8.2#36901
rogerdz wants to merge 2 commits intomagento:2.4-developfrom
rogerdz:fix-php-8.2

Conversation

@rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Feb 21, 2023

Description (*)

Fix some issue when run magento with php 8.2:

  • Error when run bin/magento indexer:reindex, bin/magento setup:di:compile
  • Error when view order have invoice, credit memo in admin
  • Error when load frontend
  • Error with shipping method in checkout
  • Error when generate static file

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2023

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@rogerdz rogerdz changed the title fix php 8.2 Fix for php 8.2 Feb 21, 2023
@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 21, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@hostep
Copy link
Contributor

hostep commented Feb 23, 2023

Hi @rogerdz

It looks like some of these changes are already included in Magento 2.4.6-beta8 as far as I can see.
No idea why these haven't been merged in 2.4-develop and pushed to github, but I suspect it will happen in one of the coming weeks.

Your changes to the pub/errors/processor.php file are better than how Adobe fixed it (they just added #[\AllowDynamicProperties] to the class which in my opinion is a bad fix, yours is better)

So maybe this PR needs to be put on hold until after the code from Magento 2.4.6 is merged and made publicly here on github...

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 24, 2023

Hi @hostep,

I agree should put PR on hold.
Besides, can you tell me where do you download magento 2.4.6-beta8 ?

@rogerdz rogerdz closed this Feb 24, 2023
@rogerdz rogerdz reopened this Feb 24, 2023
@rogerdz rogerdz marked this pull request as draft February 24, 2023 09:33
@hostep
Copy link
Contributor

hostep commented Feb 27, 2023

@rogerdz, for beta access, you need to be a Solutions/Technology Partner or (I think) have at least one client with an Adobe Commerce license.
See https://experienceleague.adobe.com/docs/commerce-operations/release/beta-program.html?lang=en for more details.

And tomorrow, the final 2.4.6 version will be available in pre-release also to the same groups of people and not yet to the general public. For the general public, it will take 2 more weeks.

@rogerdz rogerdz marked this pull request as ready for review March 14, 2023 14:41
@rogerdz
Copy link
Contributor Author

rogerdz commented Mar 14, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz rogerdz marked this pull request as draft March 14, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants