Missing default base config values can CRASH Escaper.php from a NULL value parameter.

[ergohack]

Description (*)

When the Global Default website icons are deleted, in favor of the store website icons, a NULL parameter is passed to Escaper.php and the site will crash.

Adding a sanity check avoids the crash.

[2024-12-20T17:21:42.186669+00:00] main.CRITICAL: TypeError: addslashes(): Argument #1 ($string) must be of type string, null given in /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php:440
Stack trace:
#0 /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php(440): addslashes(NULL)
#1 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/Block/Html/Header.php(62): Magento\Framework\Escaper->escapeQuote(NULL, true)
#2 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/view/frontend/templates/html/header.phtml(11): Magento\Theme\Block\Html\Header->getWelcome()

Related Pull Requests

n/a

Fixed Issues (if relevant)

n/a

Manual testing scenarios (*)

1. (optional) add at least one more website to Stores | Configurations ./admin/system_store/index/key/…
2. remove the default global website icons
3. Content | Design/Configuration ./theme/design_config/index/key/…
4. Edit the first, Global line, listed without a website.
5. delete the Favicon and default page title in the [HTML Head] section
6. delete the Logo Image and Welcome Text in the [Header] section
7. (optional) delete the Logo Image from the [Transactional Emails] section
8. Add the Favicon, page title, Logo Image and Welcome Text to the second line with an actual website.
9. (optional) Add the Favicon, page title, Logo Image and Welcome Text to the subsequent line with the second website.
10. restart the site, reload the home page [BOOM] (stack trace above)

Questions or comments

Contribution checklist (*)

• [ √ ] Pull request has a meaningful description of its purpose
• [ √ ] All commits are accompanied by meaningful commit messages
• [ - ] All new or changed code is covered with unit/integration tests (if applicable)
• [ - ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ - ] All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ergohack. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.