Remove legacy catalog_category_product_index query

[mohaelmrabet]

Description (*)

This PR removes the problematic getProductsCountQuery() method that was querying the catalog_category_product_index table, which is always empty in modern Magento installations using store-segmented indexing.

Note: No changes were made to the constructor - backward compatibility is fully maintained through existing nullable parameters and ObjectManager fallbacks.

Fixed Issues (if relevant)

1. Fixes Incorrect index table used in getProductsCountQuery() (fallback masks issue) #40320

Manual testing scenarios (*)

1. Load a category collection with product counts enabled:

$collection = $objectManager->create(\Magento\Catalog\Model\ResourceModel\Category\Collection::class);
$collection->setLoadProductCount(true)->load();

2. Verify in SQL logs that queries use catalog_category_product table and NOT catalog_category_product_index
   Confirm that product counts are accurate for categories across different stores
3. Test with both small category sets (<400) and large category sets (>400) to ensure both code paths work correctly
   Verify product counts respect website/store filtering
4. Test multi-website setup: Create products assigned to different websites and verify each website's category shows correct product count

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mohaelmrabet. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[mohaelmrabet]

@magento run all tests

[mohaelmrabet]

@magento run Static Tests

[mohaelmrabet]

@magento run Unit Tests

[mohaelmrabet]

@magento run all tests

[mohaelmrabet]

@magento run Functional Tests CE

[mohaelmrabet]

@magento run all tests