Skip to content

ef9345: Fix insert flag for the ts9347 variant in 80 columns mode #14422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

ef9345: Fix insert flag for the ts9347 variant in 80 columns mode #14422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/devices/video/ef9345.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,15 @@ void ef9345_device::bichrome80(uint8_t c, uint8_t a, uint16_t x, uint16_t y, boo
{
uint8_t c0, c1, pix[60];

const bool insert = BIT(m_dor, (a & 1) ? 7 : 3); //insert = DOR7/DOR3
c1 = (m_dor >> ((a & 1) ? 4 : 0)) & 7; //foreground color = DOR
// Undocumented difference from the EF9345: on the TS9347 the insert bit
// is taken directly from A0.
bool insert;
if (m_variant == EF9345_MODE::TYPE_EF9345)
insert = BIT(m_dor, BIT(a, 0) ? 7 : 3); //insert = DOR7/DOR3
else
insert = BIT(a, 0); //insert = A0

c1 = (m_dor >> (BIT(a, 0) ? 4 : 0)) & 7; //foreground color = DOR
c0 = m_mat & 7; //background color = MAT

if (m_variant == EF9345_MODE::TYPE_TS9347 || !BIT(c, 7)) //alphanumeric G0 set
Expand Down
Loading