Update goldstar.cpp cmast97 settings #14483
Merged
+147
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbtx77gr
commented
Nov 5, 2025
jbtx77gr
commented
- adding cmast97 correct settings
- adding cmast97 correct settings
| PORT_DIPNAME( 0x01, 0x01, "Double Up Game" ) PORT_DIPLOCATION("DSW1:!1") | ||
| PORT_DIPSETTING( 0x01, "Used" ) | ||
| PORT_DIPSETTING( 0x00, "Not Use" ) | ||
| PORT_DIPNAME( 0x02, 0x00, "Double Up Game Type" ) PORT_DIPLOCATION("DSW1:!2") |
Member
There was a problem hiding this comment.
In the case of things that are "yes/no" or "on/off", is better to use the def strings instead of some chinese "engrish". I know that is what the manual literally says, but the last thing we want is that someone jumps over due to the engrish sentences.
Member
There was a problem hiding this comment.
It’s better to use standard descriptions in general. Also we try to order settings consistently:
- Off before on
- Least generous to most generous
- Smallest to biggest
- etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.