Add missing RouteOptions to DirectionsBuilder#2573
Merged
Conversation
|
This is amazing - thank you for the updates team! cc: @pjleonard37 |
Codecov Report
@@ Coverage Diff @@
## base-v0.42.1 #2573 +/- ##
==================================================
- Coverage 40.93% 40.89% -0.04%
Complexity 1340 1340
==================================================
Files 286 286
Lines 9203 9216 +13
Branches 697 700 +3
==================================================
+ Hits 3767 3769 +2
- Misses 5105 5115 +10
- Partials 331 332 +1 |
Contributor
Author
|
@korshaknn and @RingerJK we should make sure that we're parsing all the |
kmadsen
reviewed
Mar 11, 2020
| directionsBuilder.profile(options.profile()); | ||
| } | ||
|
|
||
| if (options.alternatives() != null) { |
Contributor
There was a problem hiding this comment.
kmadsen
approved these changes
Mar 11, 2020
RingerJK
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing
RouteOptionstoDirectionsBuilderFixes #2026
bug,feature,new API(s),SEMVER, etc.)Goal
The goal is to add the options not being carried through reroutes
Implementation
Add missing options to
MapboxDirections.BuilderinNavigationRoute.Builder#routeOptionsTesting
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRmasterFix via Add missing RouteOptions to DirectionsBuilder #2582cc @EricGeiler @sridharvenkatesan @ericaeckes @tsuz @danpat @zugaldia @Aurora-Boreal