MapView logic tied into MapActivity, making it impossible to work with Fragments

[mapsforge]

From idan...@gmail.com on September 24, 2011 16:03:32

Currently, the logic in MapView is integrated with MapActivity. That didn't use to be a problem until Fragment was introduced in Honeycomb.

This makes it impossible to use a maps fragment as part as an activity. You can in theory use a MapActivity, but this solution is not clean and may affect other fragments.

I've managed to workaround the issue by refactoring MapActivity and MapView, so that MapActivity actually implements a new interface named MapContext which MapView relies on instead.

Attached is the patch I'm currently using. I have also created MapFragment which is not part of the patch, and is being used here: https://market.android.com/details?id=org.idansof.otp.ui&feature=search_result https://code.google.com/p/otp-android/

Attachment: mapsforge-mapcontext.patch

Original issue: http://code.google.com/p/mapsforge/issues/detail?id=177

[mapsforge]

From thilo.mu...@gmail.com on January 07, 2012 08:16:09

I would like to start working on this issue in the near future, but as the map library has been restructured and changed a lot in the past months, the patch is outdated. Can you please provide an updated version of your patch which can be applied against the latest version of the mapsforge-map project from the repository?

Status: Accepted
Labels: -Type-Defect Type-Enhancement

[mapsforge]

From thilo.mu...@gmail.com on January 07, 2012 09:08:46

Issue 141 has been merged into this issue.

[mapsforge]

From Stephane...@gmail.com on March 21, 2012 07:08:26

Patch updated for 0.3.0

Attachment: mapsforge-mapcontext.patch MapFragment.java

[mapsforge]

From markgabb...@gmail.com on March 23, 2012 08:09:04

Ciao, I can apply your patch but the project doesn't build. The Fragment class that you use class on Android 3.0 or Android Support Library.

I changed one line of MapFragment.java to use the Fragments from the Android support lib (line 11):

• import android.app.Fragment;
• import android.support.v4.app.Fragment;

And then I added to the mapsforge-map pom.xml file the Android support-v4 lib dependency (line 76):

            <dependency>
                    <groupId>com.google.android</groupId>
                    <artifactId>support-v4</artifactId>
                    <version> r6 </version>
                    <scope>provided</scope>
            </dependency>

[mapsforge]

From vincent....@gmail.com on May 14, 2012 01:08:35

Here is an actualized version of the patch with 3.1-SNAPSHOT current development ( r2014 ).

It includes necessary Maven dependencies. It would be appreciated if the next releases of mapsforge could include the fragments support.

Attachment: fragmentsSupport.patch

[mapsforge]

From vincent....@gmail.com on May 14, 2012 01:13:34

(Sorry for the double post)

Beware, this patch also include a bug fix in the MapView file (the overlayController thread was not stopped properly).

[mapsforge]

From flavioxa...@gmail.com on August 05, 2012 11:27:21

How is the state of this issue, I was looking to state development with maps forge and fragments.

[mapsforge]

From gregm...@mortyg.com on November 11, 2012 17:23:27

I too would like to know the status of this!

[mapsforge]

From devemu...@gmail.com on November 18, 2012 07:55:18

Probably TabHost is the only view that can embed a Activity as a view.
I have found a sample at Android issue 15347: https://code.google.com/p/android/issues/detail?id=15347#c14

[mapsforge]

From LudwigBr...@gmail.com on December 19, 2012 00:27:19

Issue 384 has been merged into this issue.

[mapsforge]

From thilo.mu...@gmail.com on January 03, 2013 10:19:21

I am currently working on a rewritten mapsforge-map library which will (besides many other improvements) also implement a solution for this issue.

Developers who are interested in the current development state should take a look at the org.mapsforge.map package of the "rewrite" branch in our Git repository. Ideas or feedback are very welcome.

Please note that the source code in this Git branch is work in progress. That means that it is unfinished, unstable, undocumented and might change at any time.

Status: Started

[mapsforge]

From ign4f...@gmail.com on March 14, 2013 01:01:54

Apply the patch fragmentsSupport.patch to the library mapsforge, import the library into your project, but I'm trying to use MapFragment Eclipse can not find MapFragment, other classes in this library Eclipse finds.
Why Eclipse can not find MapFragment?